Fix test suite

[romaricdrigon]

At the moment, tests are failing on master and on all branches (on Travis, AppVeyor is fine mostly).
On top of not being able to see the status of Maker bundle anymore, it makes contributing harder. So let's fix this!

[jrushlow]

Tasks to fix for tests to succeed

• Add missing swift mailer dependency to MakeForgottenPasswordTest

1) Symfony\Bundle\MakerBundle\Tests\Maker\MakeForgottenPasswordTest::testExecute with data set "forgotten_password" (Symfony\Bundle\MakerBundle\Test\MakerTestDetails Object (...))

Exception: Error running command: "php bin/console doctrine:database:create --env=test --if-not-exists". Output: "". Error: "

In FileLoader.php line 180:  

  There is no extension able to load the configuration for "swiftmailer" (in   
  /home/travis/build/jrushlow/maker-bundle/tests/tmp/cache/maker_app_b2f7b7e3  
  7bbd10d327bd60e4e171dbb6/config/packages/swiftmailer.yaml). Looked for name  
  space "swiftmailer", found "framework", "doctrine", "doctrine_migrations",   
  "security", "twig" in /home/travis/build/jrushlow/maker-bundle/tests/tmp/ca  
  che/maker_app_b2f7b7e37bbd10d327bd60e4e171dbb6/config/packages/swiftmailer.  
  yaml (which is loaded in resource "/home/travis/build/jrushlow/maker-bundle  
  /tests/tmp/cache/maker_app_b2f7b7e37bbd10d327bd60e4e171dbb6/config/packages  
  /swiftmailer.yaml"). 

---

I'll update the above as I progress..

[jrushlow]

• PHP CS failure

There was 1 failure:

1) Symfony\Bundle\MakerBundle\Tests\Maker\MakeForgottenPasswordTest::testExecute
 with data set "forgotten_password" (Symfony\Bundle\MakerBundle\Test\MakerTestDetails
 Object (...))

File 'src/Form/PasswordResettingFormType.php' has a php-cs problem: Loaded config
 default from "/home/travis/build/jrushlow/maker-bundle/src/Test/../Resources/test/.php_cs.test".

Using cache file ".php_cs.cache".

   1) tests/tmp/cache/maker_app_8334d22b96f9ba8c445b13fd1c406bf2/src/Form/PasswordResettingFormType.php
      ---------- begin diff ----------
--- Original
+++ New
@@ @@
 <?php
 
 namespace App\Form;
 
 use Symfony\Component\Form\AbstractType;
+use Symfony\Component\Form\Extension\Core\Type\PasswordType;
 use Symfony\Component\Form\Extension\Core\Type\RepeatedType;
-use Symfony\Component\Form\Extension\Core\Type\PasswordType;
 use Symfony\Component\Form\FormBuilderInterface;
 use Symfony\Component\OptionsResolver\OptionsResolver;
 use Symfony\Component\Validator\Constraints\Length;
 use Symfony\Component\Validator\Constraints\NotBlank;
 
 class PasswordResettingFormType extends AbstractType
 {
     public function buildForm(FormBuilderInterface $builder, array $options)
     {
         $builder
             ->add('plainPassword', RepeatedType::class, [
                 'type' => PasswordType::class,
                 'first_options' => [
                     'constraints' => [
                         new NotBlank([
                             'message' => 'Please enter a password',
                         ]),
                         new Length([
                             'min' => 6,
                             'minMessage' => 'Your password should be at least {{ limit }} characters',
                             // max length allowed by Symfony for security reasons
                             'max' => 4096,
                         ]),
                     ],
                     'label' => 'New password',
                 ],
                 'second_options' => [
                     'label' => 'Repeat Password',
                 ],
                 'invalid_message' => 'The password fields must match.',
                 // Instead of being set onto the object directly,
                 // this is read and encoded in the controller
                 'mapped' => false,
             ])
         ;
     }
 
     public function configureOptions(OptionsResolver $resolver)
     {
         $resolver->setDefaults([
             // Configure your form options here
         ]);
     }
 }
      ----------- end diff -----------

Checked all files in 0.020 seconds, 12.000 MB memory used

Failed asserting that false is true.
/home/travis/build/jrushlow/maker-bundle/src/Test/MakerTestCase.php:56
/home/travis/build/jrushlow/maker-bundle/src/Test/MakerTestCase.php:27
--

[jrushlow]

• php-cs-fixer barks at unsorted use statements

$ ./vendor/bin/php-cs-fixer fix --dry-run --diff
Loaded config default from "/home/travis/build/jrushlow/maker-bundle/.php_cs.dist".
Using cache file ".php_cs.cache".
   1) src/Maker/MakeForgottenPassword.php
      ---------- begin diff ----------
--- Original
+++ New
@@ @@
 use Symfony\Bundle\MakerBundle\Exception\RuntimeCommandException;
+use Symfony\Bundle\MakerBundle\FileManager;
 use Symfony\Bundle\MakerBundle\Generator;
 use Symfony\Bundle\MakerBundle\InputConfiguration;
+use Symfony\Bundle\MakerBundle\Renderer\FormTypeRenderer;
 use Symfony\Bundle\MakerBundle\Security\InteractiveSecurityHelper;
 use Symfony\Bundle\MakerBundle\Util\YamlSourceManipulator;
 use Symfony\Bundle\SecurityBundle\SecurityBundle;
+use Symfony\Bundle\SwiftmailerBundle\SwiftmailerBundle;
 use Symfony\Bundle\TwigBundle\TwigBundle;
 use Symfony\Component\Console\Command\Command;
 use Symfony\Component\Console\Input\InputInterface;
 use Symfony\Component\Form\AbstractType;
+use Symfony\Component\Form\Extension\Core\Type\EmailType;
 use Symfony\Component\Form\Extension\Core\Type\PasswordType;
-use Symfony\Component\Form\Extension\Core\Type\EmailType;
 use Symfony\Component\Form\Extension\Core\Type\RepeatedType;
 use Symfony\Component\Routing\RouterInterface;
-use Symfony\Bundle\MakerBundle\FileManager;
-use Symfony\Bundle\MakerBundle\Renderer\FormTypeRenderer;
 use Symfony\Component\Validator\Validation;
-use Symfony\Bundle\SwiftmailerBundle\SwiftmailerBundle;
 
 /**
  * @author Romaric Drigon <romaric.drigon@gmail.com>
  *
  * @internal
  */
 final class MakeForgottenPassword extends AbstractMaker
 {
.....
      ----------- end diff -----------

Checked all files in 2.867 seconds, 16.000 MB memory used

The command "./vendor/bin/php-cs-fixer fix --dry-run --diff" exited with 8.

[sadikoff]

Hey @romaricdrigon
I think we can close this issue because tests were fixed already, and one failed test on master not related to it.

Hey @jrushlow
Thanks for working on fixing this one test, but it's related to one maker, not suite. It should be separate issue on it.