implement types and constructor property promotion for utilities

[jrushlow]

No description provided.

[OskarStark]

I really think all property constructer promotions should be on a new line like, even if its only one:

public function __construct(
    private LoggerInterface $logger = null,
) {
}

it increases readability a lot. Not sure what you think @weaverryan

[jrushlow]

I really think all property constructer promotions should be on a new line like, even if its only one:

public function __construct(
    private LoggerInterface $logger = null,
) {
}

it increases readability a lot. Not sure what you think @weaverryan

agree'd

[jrushlow]

@OskarStark - over in symfony, do you guys use any of the #[ArrayShape] attributes instead of the param notations?

Something like https://blog.jetbrains.com/phpstorm/2020/10/phpstorm-2020-3-eap-4/#arrayshape or similar?

[OskarStark]

Can't remember

[wouterj]

No, Symfony is mostly sticking to phpDocumentor's types and annotations (with some occasional Psalm types).

[OskarStark]

Thank you Wouter 😃

[jrushlow]

Thanks Wouter! I'm getting curious about using #ArrayShape from PHPStorm, or "cloning" it in MakerBundle's NS so we can use it here. We have quite a few multi-dimensional arrays that I've run across when refactoring the code over the past couple of weeks - I'm having to jump back and forth to figure out what the array is supposed to look like.

On the flip side, this could be a sign we should be using a simple object representation instead of a complex array in those cases...

[jrushlow]

Note to self: we may be able to remove the LegacyClassMetedata - depends on doctrine version constraints...

[OskarStark]

We should always end with a ,, it makes future diffs easier to read, also there is a PHP-CS-Fixer rule

[jrushlow]

Good catch! thanks Oskar. Done in #1127