Skip to content

[csm] fix incomplete test #1132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 31, 2022
Merged

[csm] fix incomplete test #1132

merged 1 commit into from
May 31, 2022

Conversation

@jrushlow
Copy link
Collaborator

@jrushlow jrushlow commented May 31, 2022 •
edited
Loading

  • this is the only spot in maker where we consider tabs vs spaces - lets stay out of that philosophy of coding debate and just stick w/ spaces.
  • removes reflection calls that are not needed.

@jrushlow jrushlow added Status: Needs Work Additional work is needed Minor Minor Enhancement labels May 31, 2022
@jrushlow jrushlow force-pushed the csm/fix-imcomplete-test branch from 740ce8e to c11aa62 Compare May 31, 2022 13:24
@weaverryan weaverryan force-pushed the csm/fix-imcomplete-test branch from 0a4607f to 7880f09 Compare May 31, 2022 13:36
@weaverryan
Copy link
Member

weaverryan commented May 31, 2022

Thanks Jesse!

@weaverryan weaverryan merged commit 37defa0 into symfony:main May 31, 2022
@jrushlow jrushlow deleted the csm/fix-imcomplete-test branch June 1, 2022 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

Minor Minor Enhancement Status: Needs Work Additional work is needed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jrushlow @weaverryan