[tests] use composer to require maker bundle in tests #1248
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of copying MakerBundle to the flex skeleton and fiddling with autoloader to force things to work. Let's:
composer.jsoncomposer require --dev symfony/maker-bundlesrc/to the skeleton'svendor/symfony/maker-bundle/srcdirectory so we can test changes locally without having to create a commit.Caveats:
In Windows,
git cloneand symlinks are problematic. I experienced problems creating a symlink in the skeleton then attempting to clone the skeleton for individual maker tests. Workaround:composer require --dev symfony/maker-bundle+ create the symlink each time we generate a "project" from theflex_skeletonWindows AppVeyor test times have a ~4 min increase across the whole suite. This will likely be reduced when we move Windows CI to GitHub Actions.
Side note: We're doing this so we can
php-cs-fixerin each maker run w/o having to screw with the autoloader forsymfony/process