Skip to content

Conversation

@jrushlow
Copy link
Collaborator

@jrushlow jrushlow commented Dec 2, 2022

Instead of copying MakerBundle to the flex skeleton and fiddling with autoloader to force things to work. Let's:

  • add MakerBundle as a "path" repository to the skeletons composer.json
  • composer require --dev symfony/maker-bundle
  • Symlink Maker's src/ to the skeleton's vendor/symfony/maker-bundle/src directory so we can test changes locally without having to create a commit.

Caveats:

  • In Windows, git clone and symlinks are problematic. I experienced problems creating a symlink in the skeleton then attempting to clone the skeleton for individual maker tests. Workaround: composer require --dev symfony/maker-bundle + create the symlink each time we generate a "project" from the flex_skeleton

  • Windows AppVeyor test times have a ~4 min increase across the whole suite. This will likely be reduced when we move Windows CI to GitHub Actions.

Side note: We're doing this so we can php-cs-fixer in each maker run w/o having to screw with the autoloader for symfony/process

@jrushlow jrushlow added Feature New Feature Status: Needs Work Additional work is needed labels Dec 2, 2022
@jrushlow jrushlow force-pushed the feature/php-cs-fixer branch from d3cd4c9 to 46de70d Compare December 5, 2022 15:40
@jrushlow jrushlow force-pushed the feature/php-cs-fixer branch from 1b74482 to 27352ae Compare December 6, 2022 15:27
@jrushlow jrushlow changed the title WIP - [make:*] use php-cs-fixer to lint generated php files [tests] use composer to require maker bundle in tests Dec 6, 2022
@jrushlow jrushlow added Minor Minor Enhancement and removed Feature New Feature labels Dec 6, 2022
@jrushlow jrushlow added Status: Needs Review Needs to be reviewed and removed Status: Needs Work Additional work is needed labels Dec 6, 2022
@jrushlow jrushlow marked this pull request as ready for review December 6, 2022 15:38
@jrushlow jrushlow merged commit 16f26e4 into symfony:main Dec 6, 2022
@jrushlow jrushlow deleted the feature/php-cs-fixer branch December 6, 2022 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Minor Minor Enhancement Status: Needs Review Needs to be reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants