Skip to content

EntityRegenerator - no need to set annotations in tests #1260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Dec 28, 2022
Merged

EntityRegenerator - no need to set annotations in tests #1260

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
b93f376
WIP - bump minimum service contracts req
jrushlow Dec 28, 2022
b02fae1
tmp - disable annotation support in tests
jrushlow Dec 28, 2022
c4143a9
remove / disable annotation references
jrushlow Dec 28, 2022
e1c2b11
yup we still need this to support xml mapping
jrushlow Dec 28, 2022
63e25bd
Revert "WIP - bump minimum service contracts req"
jrushlow Dec 28, 2022
2e8bfaf
revert changes in subsequent prs
jrushlow Dec 28, 2022
d665076
no annotations needed
jrushlow Dec 28, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Doctrine/EntityRegenerator.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -202,7 +202,7 @@ private function createClassManipulator(string $classPath): ClassSourceManipulat
sourceCode: $this->fileManager->getFileContents($classPath),
overwrite: $this->overwrite,
// if properties need to be generated then, by definition,
// some non-annotation config is being used, and so, the
// some non-annotation config is being used (e.g. XML), and so, the
// properties should not have annotations added to them
useAttributesForDoctrineMapping: false
);
Expand Down
3 changes: 0 additions & 3 deletions tests/Doctrine/EntityRegeneratorTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,9 +159,6 @@ protected function configureContainer(ContainerBuilder $c, LoaderInterface $load
'utf8' => true,
],
'http_method_override' => false,
'annotations' => [
'enabled' => true,
],
]);

$dbal = [
Expand Down