Skip to content

Conversation

@jrushlow
Copy link
Collaborator

@jrushlow jrushlow commented May 23, 2023

v5.4.17 of phpunit-bridge fixed compatibility with doctrine/annotations:^2.0.
https://github.com/symfony/symfony/pull/48718/files#diff-7b61897762550adef47d038e61dbb44e9759b80179c8c7674fc2300c207fe751

Without the version bump to at least 5.4.17 - CI fails against 5.4.* w/ --prefer-lowest dependencies. phpunit-bridge:^5.4.7 is the lowest, but not compatible w/ MakerBundle as doctrine/annotations isn't needed.

Fixes:

PHP Fatal error:  Uncaught Error: Call to undefined method Doctrine\Common\Annotations\AnnotationRegistry::registerLoader() 
in /home/runner/work/maker-bundle/maker-bundle/vendor/symfony/phpunit-bridge/bootstrap.php:34

in several tests.

@jrushlow jrushlow force-pushed the fix/5.4-lowest-tests branch from deaa169 to 032fd45 Compare May 23, 2023 17:42
@jrushlow jrushlow marked this pull request as ready for review May 23, 2023 17:51
@jrushlow jrushlow mentioned this pull request May 23, 2023
@weaverryan
Copy link
Member

Thanks Jesse!

@weaverryan weaverryan merged commit 39903b8 into symfony:main May 30, 2023
@jrushlow jrushlow deleted the fix/5.4-lowest-tests branch March 4, 2024 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants