Add --invokable option to make:controller
#1337
Merged
+60
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weaverryan
approved these changes
Jul 18, 2023
Member
weaverryan
left a comment
weaverryan
left a comment
There was a problem hiding this comment.
Waiting for the tests - but it looks nice to me!
adrienlucas
force-pushed
the
allow-invokable-controllers
branch
from
eb6fff8 to
138f686
Compare
Contributor
Author
Fixed CS. Not sure why one of the test is failing. |
adrienlucas
force-pushed
the
allow-invokable-controllers
branch
from
9127bac to
5640423
Compare
Contributor
Author
|
Second commit : the name of the template should not be Edit : that is only for invokable controllers of course. |
weaverryan
force-pushed
the
allow-invokable-controllers
branch
from
5640423 to
74cb81a
Compare
Member
|
Awesome work - thanks for this Adrien! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows to create invokable controllers as described in the documentation.