do not implement __serialize() for users without passwords
#1743
Conversation
|
|
||
| // fetch a few packages needed for testing | ||
| MakerTestProcess::create('composer require phpunit browser-kit symfony/css-selector --prefer-dist --no-progress --no-suggest', $this->flexPath) | ||
| MakerTestProcess::create('composer require phpunit:1.1.* browser-kit symfony/css-selector --prefer-dist --no-progress --no-suggest', $this->flexPath) |
There was a problem hiding this comment.
symfony/test-pack 1.2 brings us PHPUnit 12 which the tests don't run with
There was a problem hiding this comment.
1.1.* is weird. Don't you mean 11.* instead ?
There was a problem hiding this comment.
no, phpunit is an alias for symfony/test-pack (see https://github.com/symfony/recipes/blob/main/symfony/test-pack/1.0/manifest.json#L2 and https://packagist.org/packages/symfony/test-pack#v1.1.0)
|
|
||
| MakerTestProcess::create( | ||
| \sprintf('composer create-project symfony/skeleton%s %s --prefer-dist --no-progress', $versionString, $flexProjectDir), | ||
| \sprintf('composer create-project symfony/skeleton%s %s --prefer-dist --no-progress --keep-vcs', $versionString, $flexProjectDir), |
There was a problem hiding this comment.
not sure when this broke but we need the .git directory as the created project serves as the base repository for the following tests
There was a problem hiding this comment.
IIRC, it relied on Flex running git init to create a new git repository (free from the history of the skeleton)
There was a problem hiding this comment.
ah, that might indeed explain it
There was a problem hiding this comment.
Thank you @xabbuh, this change solved the problem I faced while trying to run the repository tests.
Now, I can complete my feature.
xabbuh
force-pushed
the
ci-fix
branch
2 times, most recently
from
d18a933 to
06feabf
Compare
xabbuh
changed the title
|
👀 |
xabbuh
changed the title
xabbuh
changed the title
__serialize() for users without passwords
7 participants
No description provided.