Fix 2 YamlSourceManipulator bugs #258
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weaverryan
added a commit
that referenced
this pull request
Sep 6, 2018
This PR was squashed before being merged into the 1.0-dev branch (closes #258). Discussion ---------- Fix 2 YamlSourceManipulator bugs Fixing 2 separate bugs in `YamlSourceManipulator` reported by @nikophil. These likely aren't affecting the library now, but we'll use these situations soon in some new features :). Cheers! Commits ------- 7f4f77a Fixing a bug where we didn't convert properly from a scalar value to array 3582b1d improving some logging 15d23ae Fixing a bug where we improperly tracked indentation in 2 different ways
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing 2 separate bugs in
YamlSourceManipulatorreported by @nikophil. These likely aren't affecting the library now, but we'll use these situations soon in some new features :).Cheers!