Fixing a bug in the tests where too many deps might be installed #260
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This could create a situation where we tell a user to install libraries A, B & C only, but really, we also depend on library D, which was not recommended because we are missing that dependency from our Maker. However, library D may have been installed in the functional test (because we previously installed ALL dependencies, even if it was related to a class we already had).
weaverryan
force-pushed
the
fix-dependencies-functional-test
branch
from
ef9b61a to
ddd3ed4
Compare
Also, one test case has an optional Doctrine dep, but we need it for the test - so, including it.
weaverryan
force-pushed
the
fix-dependencies-functional-test
branch
from
ddd3ed4 to
1c3002c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This could create a situation where we tell a user to install libraries
A, B & C only, but really, we also depend on library D, which was
not recommended because we are missing that dependency from our Maker.
However, library D may have been installed in the functional test
(because we previously installed ALL dependencies, even if it was
related to a class we already had).
This would have caught #256.