Skip to content

Conversation

@tgalopin
Copy link
Contributor

🧙

Copy link
Member

@nicolas-grekas nicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

Copy link

@damienalexandre damienalexandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lyrixx
Copy link
Member

lyrixx commented Sep 21, 2018

How does it behave on system that does not support it? (we may don't care :) )

@weaverryan
Copy link
Member

Indeed... thanks has some "magic" logic for that 🎩

https://github.com/symfony/thanks/blob/master/src/Thanks.php#L87-L93

@javiereguiluz
Copy link
Member

Does anyone see a wizard here?

error-1

error-2

@tgalopin
Copy link
Contributor Author

Updated :)

@nicolas-grekas
Copy link
Member

nicolas-grekas commented Sep 21, 2018

@javiereguiluz

@javiereguiluz
Copy link
Member

@tgalopin I'm on a macOS computer and still can't see this emoji:

error-3

@tgalopin
Copy link
Contributor Author

It's a question of font. Do you see other emojis, like in thanks code?

@javiereguiluz
Copy link
Member

@tgalopin yes, I can see all emojis perfectly ... but not the one you added here. I only see an empty square.

@ogizanagi
Copy link

ogizanagi commented Sep 21, 2018

@javiereguiluz : You might still be on OS X Sierra, but this emoji is part of Unicode 10 for which the Apple Color Emoji font was only updated since High Sierra.

Note: You can try installing the emoji-one font or get a more recent version of the Apple font from another High Sierra install.

@javiereguiluz
Copy link
Member

@ogizanagi you are right ... and that was my point: we may be trying to use a too new emoji ... which is not seen by some (lots?) of users. Please, think twice before merging it 🙏 Thanks!

@nicolas-grekas
Copy link
Member

As time passes, this compat issue will disappear. Given the outcome is a simple square, I'm all for merging this now :)

@weaverryan
Copy link
Member

We did it! Thanks Tito ;)

@weaverryan weaverryan closed this in 14d2946 Oct 1, 2018
@tgalopin tgalopin deleted the patch-1 branch October 1, 2018 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants