-
-
Notifications
You must be signed in to change notification settings - Fork 439
Add a wizard emoji #276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a wizard emoji #276
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❤️
damienalexandre
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✨
|
How does it behave on system that does not support it? (we may don't care :) ) |
|
Indeed... thanks has some "magic" logic for that 🎩 https://github.com/symfony/thanks/blob/master/src/Thanks.php#L87-L93 |
|
Updated :) |
|
@tgalopin I'm on a macOS computer and still can't see this emoji: |
|
It's a question of font. Do you see other emojis, like in thanks code? |
|
@tgalopin yes, I can see all emojis perfectly ... but not the one you added here. I only see an empty square. |
|
@javiereguiluz : You might still be on OS X Sierra, but this emoji is part of Unicode 10 for which the Apple Color Emoji font was only updated since High Sierra. Note: You can try installing the emoji-one font or get a more recent version of the Apple font from another High Sierra install. |
|
@ogizanagi you are right ... and that was my point: we may be trying to use a too new emoji ... which is not seen by some (lots?) of users. Please, think twice before merging it 🙏 Thanks! |
|
As time passes, this compat issue will disappear. Given the outcome is a simple square, I'm all for merging this now :) |
|
We did it! Thanks Tito ;) |




🧙