Throwing CustomUserMessageAuthenticationException in make:auth login #281
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
form The idea is that this is easier and more self-documenting than teaching the user to translate the "Username could not be found." message.
weaverryan
added a commit
that referenced
this pull request
Oct 4, 2018
…e:auth login (weaverryan)
This PR was merged into the 1.0-dev branch.
Discussion
----------
Throwing CustomUserMessageAuthenticationException in make:auth login
The idea is that this is easier and more self-documenting than teaching the user to translate the "Username could not be found." message.
```diff
// src/Security/LoginFormAuthenticator.php
// ...
public function getUser($credentials, UserProviderInterface $userProvider)
{
// ...
- return $this->entityManager->getRepository(User::class)->findOneBy([
+ $user = $this->entityManager->getRepository(User::class)->findOneBy([
'email' => $credentials['email'],
]);
+ if (!$user) {
+ // fail authentication with a custom error
+ throw new CustomUserMessageAuthenticationException('Email could not be found.');
+ }
+ return $user;
}
```
Cheers!
Commits
-------
5f9fead Throwing CustomUserMessageAuthenticationException in make:auth login form
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The idea is that this is easier and more self-documenting than teaching the user to translate the "Username could not be found." message.
// src/Security/LoginFormAuthenticator.php // ... public function getUser($credentials, UserProviderInterface $userProvider) { // ... - return $this->entityManager->getRepository(User::class)->findOneBy([ + $user = $this->entityManager->getRepository(User::class)->findOneBy([ 'email' => $credentials['email'], ]); + if (!$user) { + // fail authentication with a custom error + throw new CustomUserMessageAuthenticationException('Email could not be found.'); + } + return $user; }Cheers!