Skip to content

Mention what you should throw in your UserProvider #291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Mention what you should throw in your UserProvider #291

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c56c59e
Mention what you should throw in your UserProvider
weaverryan Oct 13, 2018
803a4fe
Not needed: IDE's are smart enough due to the instanceof check
weaverryan Oct 13, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/Resources/skeleton/security/UserProvider.tpl.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,8 @@ class <?= $class_name ?> implements UserProviderInterface
* this method.
*
* @return UserInterface
*
* @throws UsernameNotFoundException if the user is not found
*/
public function loadUserByUsername($username)
{
Expand Down Expand Up @@ -46,8 +48,6 @@ public function refreshUser(UserInterface $user)
throw new UnsupportedUserException(sprintf('Invalid user class "%s".', get_class($user)));
}

/* @var <?= $user_short_name ?> $user */

// Return a User object after making sure its data is "fresh".
// Or throw a UsernameNotFoundException if the user no longer exists.
throw new \Exception('TODO: fill in refreshUser() inside '.__FILE__);
Expand Down