Fixed issue with no entity directory in symfony 3.4

[yuriy-yakubskiy]

Hey guys,

The following could fix an issue without adding extra config to maker.

Symfony Version: 3.4
Maker Bundle: 1.8.0 and master
Bug Fix: #265, #299

P.S

1. Failed to find the way to add a test for Symfony 3.4 only 4+ tests are supported currently

2. Unfortunately can't fix as proposed in the following comment
   "make:entity" root directory location improvment #265 (comment)
   if call $cmf->getAllMetadata() before generate entity it couldn't be loaded by calling getAllMetadata again.
   See the following commit in other branch yuriy-yakubskiy@8b66999

Thanks!

[weaverryan]

Hey @yuriy-yakubskiy!

Thanks for taking this on! There is now a "competing" PR - #311. That approach looks good to me... however, the tests are failing. And I'm wondering you "hit" the same issue that the tests are hitting in #311. Specifically, can you explain your comment a bit more:

Unfortunately can't fix as proposed in the following comment #265 (comment)
if call $cmf->getAllMetadata() before generate entity it couldn't be loaded by calling getAllMetadata again.
See the following commit in other branch yuriy-yakubskiy/maker-bundle@8b66999

Thanks!

[yuriy-yakubskiy]

Hey @weaverryan !

The main problem is that if use DoctrineHelper for auto-completing entity names it loads doctrine metadata

maker-bundle/src/Doctrine/DoctrineHelper.php

Line 135 in cc5c0d9

$loaded = $cmf->getAllMetadata();

before generate an entity class. Then after entity is generated application checks if class exists here

maker-bundle/src/Maker/MakeEntity.php

Line 152 in cc5c0d9

$classExists = class_exists($entityClassDetails->getFullName());

but as metadata was loaded without this class it returns false and application and test accordingly fails on this stage.
I tried but failed to find a way to let know the auto-loader that there is a new generated entity class...

Hope it explains more or less the issue.

Cheers

[weaverryan]

Merged #311 - thanks for starting this!