Skip embedded fields in embeddables #316
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cedricziel
force-pushed
the
mapped-embeddable
branch
from
bc9e2fb to
8464365
Compare
Member
|
Hey @cedricziel! This is an excellent change! But could you add a test for it? There are a lot of test cases already in the Thanks! |
This change skips the creation of mapped fields inside embeddables.
Consider the PHP Money class:
```php
public class Invoice {
/**
* @var Money
*
* @Orm\Embedded(class="Money\Money")
*/
private $total;
}
```
```php
final class Money implements \JsonSerializable {
/**
* @var Currency
*/
private $currency;
}
```
Here, Money has the mapped field `Currency`. In doctrine Metadata,
this is correctly reflected as `total.currency`.
The EntityRegenerator declares a private field `$total.currency` afterwards.
The changeset suppresses this behaviour by skipping fields containing a
dot as is done a few lines below.
cedricziel
force-pushed
the
mapped-embeddable
branch
from
8464365 to
5c48add
Compare
Member
|
Thank you Cedric! |
weaverryan
added a commit
that referenced
this pull request
Mar 1, 2019
This PR was squashed before being merged into the 1.0-dev branch (closes #316). Discussion ---------- Skip embedded fields in embeddables This change skips the creation of mapped fields inside embeddables. Consider the PHP Money class: ```php public class Invoice { /** * @var Money * * @Orm\Embedded(class="Money\Money") */ private $total; } ``` ```php final class Money implements \JsonSerializable { /** * @var Currency */ private $currency; } ``` Here, Money has the mapped field `Currency`. In doctrine Metadata, this is correctly reflected as `total.currency`. The EntityRegenerator declares a private field `$total.currency` afterwards. The changeset suppresses this behaviour by skipping fields containing a dot as is done a few lines below. Commits ------- a4d4787 Embed money objects 074f836 Remove double slash 6b9f7d8 Map embeddable money test with XML for convenience 84e2f58 Add small test to embeddable test 5c48add Skip embedded fields in embeddables
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change skips the creation of mapped fields inside embeddables.
Consider the PHP Money class:
Here, Money has the mapped field
Currency. In doctrine Metadata,this is correctly reflected as
total.currency.The EntityRegenerator declares a private field
$total.currencyafterwards.The changeset suppresses this behaviour by skipping fields containing a
dot as is done a few lines below.