Look for the target entity in the namespace first #360
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
I don't know if the tests is enought, I've only created one for a self-referencing ManyToOne |
Member
|
Thank you Antal - excellent job fixing this! |
weaverryan
added a commit
that referenced
this pull request
Mar 1, 2019
This PR was squashed before being merged into the 1.0-dev branch (closes #360). Discussion ---------- Look for the target entity in the namespace first As in #322 the entity maker cannot make a relation, where the target entity is also presented in the root namespace, beacuse `Symfony\Bundle\MakerBundle\Maker\MakeEntity::askRelationDetails()` looks for it in the root namespace at first. I don't think this is the good behaviour. This PR makes it look for first in the namepace defined in the config, and after that in other places. Commits ------- 1003c21 Swap target entity namespace search 7fb5a31 Reproduce the error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As in #322 the entity maker cannot make a relation, where the target entity is also presented in the root namespace, beacuse
Symfony\Bundle\MakerBundle\Maker\MakeEntity::askRelationDetails()looks for it in the root namespace at first.I don't think this is the good behaviour.
This PR makes it look for first in the namepace defined in the config, and after that in other places.