Skip to content

Conversation

@pluseg
Copy link

@pluseg pluseg commented Jun 6, 2019

It fixes #395.
There are hardcoded non-existent classes for Voter and Normalizer.

@lyrixx
Copy link
Member

lyrixx commented Jun 6, 2019

I saw the issue, But with this patch, I will have to edit more code. I don't see the benefit here.

Instead I would try to guess the entity name base on the Voter FQCN

@pluseg
Copy link
Author

pluseg commented Jun 8, 2019

@lyrixx I think that FQCN doesn't require to mention an entity name.

I will have to edit more code
It's the same amount, just delete comments and place your own logic. Or uncomment the example.

ps. I've noticed that I forgot a return false; statement. My bad.

@pluseg pluseg force-pushed the issue/395-remove-hardcoded-entities branch from 75f9b3c to e168b51 Compare June 8, 2019 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

"BlogPost" hardcoded in templates for Normalizer and Voter

9 participants