[Validator] added reserved keywords in validateClassName method #461
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javiereguiluz
approved these changes
Sep 20, 2019
Member
javiereguiluz
left a comment
javiereguiluz
left a comment
There was a problem hiding this comment.
Thanks for fixing this!
This change can be verified with the official list of PHP keywords: https://www.php.net/manual/en/reserved.keywords.php
maxhelias
approved these changes
Sep 20, 2019
romaricdrigon
approved these changes
Oct 11, 2019
Contributor
|
The official list of PHP keyword is now covered, thank you @WinterUni |
romaricdrigon
added
Status: Reviewed
Member
|
Thank you @WinterUni! |
weaverryan
added a commit
that referenced
this pull request
Oct 18, 2019
…hod (WinterUni) This PR was merged into the 1.0-dev branch. Discussion ---------- [Validator] added reserved keywords in validateClassName method Commits ------- 51d843a [Validator] added reserved keywords in validateClassName method
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.