Skip to content

Missing return statement in example #467

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 18, 2019
Merged

Missing return statement in example #467

merged 1 commit into from
Oct 18, 2019

Conversation

@snebes
Copy link
Contributor

@snebes snebes commented Sep 2, 2019

Missing return statement in example SecurityController. Added a missing space as well.

@romaricdrigon romaricdrigon added Status: Reviewed Has been reviewed by a maintainer Related Tests Pass labels Oct 11, 2019
@weaverryan
Copy link
Member

weaverryan commented Oct 18, 2019

Thank you for catching this and fixing it @snebes! :)

@weaverryan weaverryan merged commit 7b5c7d0 into symfony:master Oct 18, 2019
@snebes snebes deleted the missing-return-statement-in-example branch October 18, 2019 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@javiereguiluz javiereguiluz javiereguiluz approved these changes

+2 more reviewers

@romaricdrigon romaricdrigon romaricdrigon approved these changes

@maxhelias maxhelias maxhelias approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Related Tests Pass Status: Reviewed Has been reviewed by a maintainer

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@snebes @weaverryan @javiereguiluz @romaricdrigon @maxhelias