Changed placeholder to real label #486
Conversation
|
Hello, |
|
Just some quick links why placeholders should be avoided: https://uxdesign.cc/alternatives-to-placeholder-text-13f430abc56f |
|
This looks reasonable - and we're still using Bootstrap markup, so sure - let's do it :). Thanks Thomas! |
This PR was merged into the 1.0-dev branch. Discussion ---------- Changed placeholder to real label Although common, placing the label into the placeholder is bad practice and reduces usability and accessibility. If people wanna do it this way, they still can; but it shouldn't be suggested :-) If you merge it, I'll update the docs at https://symfony.com/doc/current/security/form_login_setup.html#generating-the-login-form too. Commits ------- fd5a6d5 Changed placeholder to real label
|
Just tagged a patch release - so could you please update the docs @ThomasLandauer? Thanks! |
|
Update the docs at 5.0 master https://symfony.com/doc/master/security/form_login_setup.html or which branch? BTW: Is there a long-term plan to get rid of Bootstrap? |
3 participants
Although common, placing the label into the placeholder is bad practice and reduces usability and accessibility. If people wanna do it this way, they still can; but it shouldn't be suggested :-)
If you merge it, I'll update the docs at https://symfony.com/doc/current/security/form_login_setup.html#generating-the-login-form too.