Tests structure optimization #511
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sadikoff
force-pushed
the
optimize-tests
branch
from
8ae656a to
76c020b
Compare
sadikoff
changed the title
weaverryan
reviewed
Dec 16, 2019
| $event .= sprintf(' (<fg=yellow>%s</>)', self::$eventsMap[$event]); | ||
| } | ||
|
|
||
| return $events; |
Member
There was a problem hiding this comment.
Can you describe what this is doing exactly? I have a hard time just reading the code to figure it out :)
Contributor
Author
There was a problem hiding this comment.
It generates more verbose event describing
Contributor
Author
There was a problem hiding this comment.
Also, I restored old-style event keys like kernel.request because it's still described in symfony5 before it command asked the user to enter long FQCN for RequestEvent class.
Member
|
Thank you Vladimir! This organization is much more sane now :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!!! It's again me with some crazy test stuff 😄 Hope it will improve debugging!
ping @romaricdrigon and @weaverryan
closes #498