Fix SecurityConfigUpdater #546
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chalasr
approved these changes
Feb 17, 2020
|
|
||
| foreach ($newData['security']['firewalls'] as &$firewall) { | ||
| if (($firewall['provider'] ?? null) === $memoryProviderName) { | ||
| $firewall['provider'] = 'app_user_provider'; |
Member
There was a problem hiding this comment.
👍 For the record, we prefer setting the provider explicitly. See symfony/recipes#741
wouterj
approved these changes
Feb 28, 2020
fabpot
approved these changes
Mar 2, 2020
since we remove memory provider in "make:user" if it is the only provider, we need to remove this memory provider from firewalls.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this fixes the bug which occurs presently on master
since we remove memory provider in "make:user" if it is the only
provider, we need to remove this memory provider from firewalls.
And the tests were failing now because the security bundle's recipe has been updated recently, and the memory provider has been added to main firewall