php8 attributes support for generated controllers #725
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weaverryan
changed the title
weaverryan
reviewed
Nov 1, 2020
weaverryan
reviewed
Nov 2, 2020
Member
weaverryan
left a comment
weaverryan
left a comment
There was a problem hiding this comment.
Minor comments!
I think we should kill/fix ALL the @Route in this one PR:
git grep '@Route' src/Resources/skeleton
It's only 3 other templates I think.
tests/fixtures/MakeControllerAttributes/tests/GeneratedControllerTest.php
Outdated
Show resolved
Hide resolved
jrushlow
force-pushed
the
feature/controller-annotations
branch
from
6ac4fae to
c6eba1c
Compare
jrushlow
changed the title
jrushlow
commented
Nov 3, 2020
jrushlow
commented
Nov 3, 2020
jrushlow
commented
Nov 3, 2020
jrushlow
commented
Nov 3, 2020
jrushlow
commented
Nov 3, 2020
jrushlow
commented
Nov 3, 2020
| * | ||
| <?php if ($use_attributes) { ?> | ||
| */ | ||
| #[Route('', name: 'app_forgot_password_request')] |
Collaborator
Author
There was a problem hiding this comment.
the empty '' path was added on purpose when we first created this maker - but I don't remember exactly why we decided to do this. Will investigate and adjust accordingly under a separate issue.
Member
There was a problem hiding this comment.
I also can't remember... it may have been that / here would have made the final URL have a trailing slash - /reset-password/
weaverryan
approved these changes
Nov 4, 2020
| * | ||
| <?php if ($use_attributes) { ?> | ||
| */ | ||
| #[Route('', name: 'app_forgot_password_request')] |
Member
There was a problem hiding this comment.
I also can't remember... it may have been that / here would have made the final URL have a trailing slash - /reset-password/
weaverryan
force-pushed
the
feature/controller-annotations
branch
from
a3e1ea8 to
75532b5
Compare
Member
|
Thank you Jesse! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using PHP8, Maker Bundle uses route attributes in the generated controllers instead of annotations.
As Doctrine/ORM does not currently have PHP8 support, we are unable to test the route functionality for
crud,registration-form, &reset-password. No additional tests should be needed when Doctrine is PHP8 compatible.