only use attributes if PHP >= 8 && Symfony >= 5.2 #760
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrushlow
added
Status: Needs Work
weaverryan
reviewed
Dec 7, 2020
| $version = $this->getPhpVersion(); | ||
|
|
||
| return version_compare($version, '8alpha', '>='); | ||
| return version_compare($version, '8alpha', '>=') && Kernel::VERSION_ID >= 50200; |
Member
There was a problem hiding this comment.
We should probably make this method more specific. This is really about routing attributes. But soon we will probably start using Doctrine attributes and then other things. Possibly we could rename this to canUseRouteAttributes() and add other methods later.
weaverryan
force-pushed
the
fix/attributes-before-52
branch
from
abbaee7 to
4dd942f
Compare
Member
|
I did leave one comment I think we should address later, but as this is internal and fixes a bug, merging now. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #750