Reference::isStrict() is gone in Symfony 3.0

[derrabus]

The LoggerChannelPass contains calls to Symfony\Component\DependencyInjection\Reference::isStrict(), a method that has been removed from Symfony 3. The test case LoggerChannelPassTest fails if you run it against the Symfony master branch.

This pull request adds a forward-compatible code that checks with method_exists() if the method is still present. That check may be removed in the future, as soon as support for Symfony 2 is dropped. Tests are now running green with Symfony 2.7.4 and 3.0-dev.

[derrabus]

The method was removed with PR symfony/symfony#15693.

[fabpot]

👍

[fabpot]

That's actually the only remaining patch to make the Symfony SE work for Symfony 3.0. At least, to make Composer happy :)

[stof]

no need to use else here as the previous if returns

[derrabus]

@stof Thank you for your review. I've followed both of your suggestions.

[stof]

Thank you @derrabus.

[Tobion]

This still triggers alot of deprecation warnings when warming the cache in the standard edition. We need a different solution. We could just use $reference->isStrict(false) to prevent the deprecation warning. Or can we not ignore the strict flag completely? It's rather unlikely to have a scope problem with a logger...

[derrabus]

$reference->isStrict(false) is probably the way to go. Ignoring the strict flag might cause problems with bundles that still rely on the deprecated behavior.