Don't trigger a deprecation warning for Reference::isStrict() #141
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
👍 |
1 similar comment
Contributor
|
👍 |
Seldaek
added a commit
that referenced
this pull request
Oct 29, 2015
Don't trigger a deprecation warning for Reference::isStrict()
Member
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As @Tobion pointed out in a comment to my merged PR #138, the
LoggerChannelPassstill triggers deprecation warnings with Symfony 2.8. When writing my patch, I was not aware that I could suppress the warning by passingfalseas parameter toReference::isStrict().I think, suppressing the warning is the way to go because we already took care of the deprecation in #138: Once
isStrict()is gone, it won't be called anymore. But as long as it's still there, other bundles might be using that functionality, so imho there's no way around callingisStrict()without potentially breaking stuff.