Skip to content

[CS] Removed property used only in constructor #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dunglas merged 1 commit into from
Apr 16, 2018
Merged

[CS] Removed property used only in constructor #19

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions src/ProcessManager/WebServerManager.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@ final class WebServerManager
{
use WebServerReadinessProbeTrait;

private $documentRoot;
private $hostname;
private $port;

Expand All @@ -37,7 +36,6 @@ final class WebServerManager
*/
public function __construct(string $documentRoot, string $hostname, int $port)
{
$this->documentRoot = $documentRoot;
$this->hostname = $hostname;
$this->port = $port;

Expand All @@ -46,7 +44,7 @@ public function __construct(string $documentRoot, string $hostname, int $port)
throw new \RuntimeException('Unable to find the PHP binary.');
}

$this->process = new Process([$binary] + $finder->findArguments() + ['-dvariables_order=EGPCS', '-S', \sprintf('%s:%d', $this->hostname, $this->port)], $this->documentRoot, null, null, null);
$this->process = new Process([$binary] + $finder->findArguments() + ['-dvariables_order=EGPCS', '-S', \sprintf('%s:%d', $this->hostname, $this->port)], $documentRoot, null, null, null);
}

public function start(): void
Expand Down