Skip to content

Allowing customization of host and port for ChromeManager #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dunglas merged 6 commits into from
May 18, 2018
Merged

Allowing customization of host and port for ChromeManager #22

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
132a0b4
Allowing customization of host and port for ChromeManager
cryptiklemur May 11, 2018
b93f437
Update ChromeManager.php
cryptiklemur May 11, 2018
7d69646
Update ChromeManager.php
cryptiklemur May 11, 2018
7deea57
Update ChromeManager.php
cryptiklemur May 11, 2018
c28b263
Style fixes
cryptiklemur May 11, 2018
891c8c5
Removing ?
cryptiklemur May 13, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 17 additions & 4 deletions src/ProcessManager/ChromeManager.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,11 +28,13 @@ final class ChromeManager implements BrowserManagerInterface

private $process;
private $arguments;
private $options;

public function __construct(?string $chromeDriverBinary = null, ?array $arguments = null)
public function __construct(?string $chromeDriverBinary = null, ?array $arguments = null, array $options = [])
{
$this->process = new Process([$chromeDriverBinary ?? $this->findChromeDriverBinary()], null, null, null, null);
$this->arguments = $arguments ?? $this->getDefaultArguments();
$this->options = \array_merge($this->getDefaultOptions(), $options);
}

/**
Expand All @@ -42,10 +44,11 @@ public function __construct(?string $chromeDriverBinary = null, ?array $argument
*/
public function start(): WebDriver
{
$url = $this->options['scheme'].'://'.$this->options['host'].':'.$this->options['port'];
if (!$this->process->isRunning()) {
$this->checkPortAvailable('127.0.0.1', 9515);
$this->checkPortAvailable($this->options['host'], $this->options['port']);
$this->process->start();
$this->waitUntilReady($this->process, 'http://127.0.0.1:9515/status');
$this->waitUntilReady($this->process, $url.$this->options['path']);
}

$capabilities = DesiredCapabilities::chrome();
Expand All @@ -55,7 +58,7 @@ public function start(): WebDriver
$capabilities->setCapability(ChromeOptions::CAPABILITY, $chromeOptions);
}

return RemoteWebDriver::create('http://localhost:9515', $capabilities);
return RemoteWebDriver::create($url, $capabilities);
}

public function quit(): void
Expand Down Expand Up @@ -89,4 +92,14 @@ private function getDefaultArguments(): array

return $args;
}

private function getDefaultOptions(): array
{
return [
'scheme' => 'http',
'host' => '127.0.0.1',
'port' => 9515,
'path' => '/status',
];
}
}