Add checks for each mb_* function separately
#7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
@capuderg I think you need to submit the PR to this repo: https://github.com/symfony/polyfill |
|
What @JanJakes said :) |
|
Sorry about that. Didn't see the comment to open a PR there :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in PR #6, this would be a potential fix for any corner case.
Currently, we have issue with
mb_strtolowernot being polyfilled, because the current check only checks ifmb_strlenexists.In WordPress the
mb_strlenfunction is polyfilled before this package can be required, but themb_strtoloweris not (don't know why WP is polyfilling just a few).With this change, all
mb_*functions can be polyfilled separately.