Fix grapheme_str_split() on PCRE 8#616
Merged
Merged
Conversation
The PCRE 8 implementation of \X doesn't have the fix from 10.44.
Member
|
Thank you @GPHemsley. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#598 bumped the PCRE2 version requirement from 10.39 to 10.44, in order to take advantage of the fix for PCRE2Project/pcre2#410, but left the PCRE1 version untouched at 8.32.
But the necessary fix was made 3 years after PCRE1 was EOL'd, so there is no 8.x version in which
\Xworks the way grapheme_str_split() needs it to.PHP 7.2.0 was bundled with PCRE1 8.41 before PHP 7.3.0 changed to PCRE2 10.32:
https://www.php.net/manual/en/pcre.installation.php
Falling back to the now-updated regex seems to work fine, though.