fix: Correctly define MySQL constants#618
Merged
Merged
Conversation
keulinho
reviewed
May 26, 2026
keulinho
reviewed
May 26, 2026
nicolas-grekas
force-pushed
the
fix/mysql-constants
branch
from
aba76a5 to
99c21df
Compare
Member
|
Thank you @mitelg. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
hey 👋
the change made in #590 was wrong and is now breaking our CI pipeline.
The author assumed, the constants where defined under the same condition (see #590 (comment)), but actually they are not. If you look closely you see that there is first used a
#ifndef(mind the n) and theATTR_SSL_VERIFY_SERVER_CERTconstant is defined with#ifdef(no n).not sure if an additional condition is the correct solution, but checking for all four constants at the same time is definitely not correct. But having an additional check should also fix the original authors problem