Skip to content

Packs must never add/modify files in a project #988

@fabpot

Description

@fabpot

As we always unpack packs now and because we are using Composer to uninstall the pack, the recipes are removed automatically by the Composer plugin/hooks.

It means that a pack CANNOT have anything in the recipes that modifies the local files, so env var, so file creation, ...
In any case, even if we would want to "fix" that, it's not worth it as we are losing the reference to the pack in symfony.lock, so we won't be able to update the files whenever the recipe changes.

So, I propose to document that new rule: a pack cannot modify the local filesystem in a recipe and add a corresponding Github action check to ensure nobody tries that.

For existing packs that break this new rule, we must find other ways. The simplest way is to create an empty package with an attached recipe that is required in the pack.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions