Move PHPUnit tests folder into the root folder

[bocharsky-bw]

No description provided.

[javiereguiluz]

👍

[javiereguiluz]

I agree with this change, but I'd like to read other opinions. Apparently, Symfony doesn't recommend this practice officially.

[bocharsky-bw]

I'm wondering to hear other opinions too. BTW, symfony-standard already moved DefaultControllerTest into the tests directory:
https://github.com/symfony/symfony-standard/blob/master/tests/AppBundle/Controller/DefaultControllerTest.php
And autoloads tests from tests dir in composer.json

[voronkovich]

I think that holding the folder with tests in the root directory just makes it easier to launch the tests: phpunit vs. phpunit -c app. 👍

[javiereguiluz]

@voronkovich good point ... but if I'm right, that's achieved by moving the phpunit.xml.dist config file to the root directory. That's what Symfony 3.x did and we can run the tests with phpunit even if they are located inside src/

[voronkovich]

@javiereguiluz, you're right, I mistakenly confused the test directory and phpunit.xml file. So, I don't have any opinion about this PR :(

[voronkovich]

@javiereguiluz, there is an explanation why tests folder was moved to the root directory in the symfony-standard. See symfony/symfony-standard@d0311d2#commitcomment-15653984

[xabbuh]

The namespace of the SluggerTest class needs to be updated too.

[bocharsky-bw]

@xabbuh Yes, I know. It's weird, but it already has a right namespace in master. Actually, I think we have a bug now in master, but this PR should fix it.

[xabbuh]

@bocharsky-bw But the namespace should be Tests\AppBundle\Utils, shouldn't it?

[xabbuh]

And to be consistent with the Symfony Standard Edition we would need to have a tests/AppBundle directory.

[bocharsky-bw]

@xabbuh Ah, you're totally right, I missed AppBundle.

Thanks for notice it! I'll fix it soon.

[bocharsky-bw]

Done.

[xabbuh]

👍

[javiereguiluz]

Thank you @bocharsky-bw.