Changing links in Testing section to valid #19556
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
@pawelwaw-git thanks a lot for this contribution. Your proposed changes are not wrong, but we've decided to close this PR as "won't merge". The reason is that we fixed this problem in a different way in #19567. The reason is that we prefer to keep the links to 10.x version instead of upgrading to 11.x (which we'll do in the future, of course). It's sad that we didn't merge your PR ... but I hope that you send other PRs in the future. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found 3 links which return 404 code
so I changed to new links from PHPUnit docs.
I decided to use the last version, but I am not sure if this should be the appropriate decision.