Skip to content

Simplify boolean condition in datetime handling #20028

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Simplify boolean condition in datetime handling #20028

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion serializer/custom_context_builders.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ value is ``0000-00-00``. To do that you'll first have to create your normalizer:

public function supportsDenormalization($data, string $type, ?string $format = null, array $context = []): bool
{
return true === ($context['zero_datetime_to_null'] ?? false)
return ($context['zero_datetime_to_null'] ?? false)
Copy link
Member

@javiereguiluz javiereguiluz Jul 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know much about the serializer ... but this change is not exactly the same. Before, only true (and false) are valid. If we remove the true === condition, any value that converts to true (like (int) 2 or (string) foo) will be allowed too.

But maybe I'm missing something here.

Copy link
Contributor

@OskarStark OskarStark Jul 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would say you are right @javiereguiluz

https://3v4l.org/cWCSA

&& is_a($type, \DateTimeInterface::class, true);
}
}
Expand Down