Missing line for example #3483
Closed
Missing line for example #3483
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I just mentioned the fact that `push -f` is usually required when rebasing and explicit that the "2.2 when bugfixing" is a follow up on the previous example (Not necessarily explicit at first).
As per WouterJ request: #3421 (comment)
Fixed TokenInterface use statement causing compile errors
As per @cordoval suggestion: #3421 (comment)
…time option (bicpi) This PR was merged into the 2.3 branch. Discussion ---------- [Reference][Form Types] Document "with_minutes" time/datetime option | Q | A | ------------- | --- | Doc fix? | yes | New docs? | yes | Applies to | 2.3+ | Fixed tickets | #3410 (task `time > with_minutes`) The `datetime` field also has a `with_minutes` option. Using the `single_text` widget type might not work as expected using `with_minutes=false` if the browser supports HTML5's `time` input type. Most browsers seem to only support `hh:mm` or `hh:mm:ss` formats for the value attribute (resetting the value to `--:--` if using an hour value only). This might not be the case for every browser because I couldn't find anything in the HTML5 spec that says a partial time cannot be an hour only. I've added a `caution` box for this. Commits ------- 1e88b9d Fix "versionadded" position 8cfb850 [Reference][Form Types] Document "with_minutes" time/datetime option
Change the use statement of TokenInterface to the correct namespace (missing Token folder)
… (lemoinem) This PR was merged into the 2.4 branch. Discussion ---------- [Contributing] Cleaning the "contributing patch" page a bit | Q | A | ------------- | --- | Doc fix? | no | New docs? | no | Applies to | all | Fixed tickets | N/A I just mentioned the fact that `push -f` is required when rebasing and explicit that the "2.2 when bugfixing" is a follow up on the previous example (Not necessarily explicit at first). I also worked my way through the all document to replace wrong single back-tick occurrences by double backticks. Finally, I converted the mentions of PSR-1 and PSR-2 to links toward the respective PSR. PS: as per @wouterj request (#3421 (comment)), I also replaced mentions of 2.2 by 2.3 Commits ------- c0de1cb [Contributing] Replace HEAD~3 by upstream/master 732758b [Contributing] Fix "When you finish" => "When you are finished" b25ec96 [Contributing] Replace mentions of 2.2 for 2.3 70ed645 [Contributing] Add PSR-1 and 2 links 6796ba8 [Contributing] Fix single vs double backtick issues b35e62b [Contributing] Clarify the rebase operation
I just mentioned the fact that `push -f` is usually required when rebasing and explicit that the "2.2 when bugfixing" is a follow up on the previous example (Not necessarily explicit at first).
As per WouterJ request: #3421 (comment)
As per @cordoval suggestion: #3421 (comment)
…2.4 (singles) This PR was merged into the 2.4 branch. Discussion ---------- Translation - Added info about JsonFileLoader added in 2.4 | Q | A | ------------- | --- | Doc fix? | no | New docs? | yes (symfony/symfony#8534) | Applies to | 2.4 | Fixed tickets | n/a Commits ------- adf678b Added info about JsonFileLoader added in 2.4
This PR was merged into the 2.4 branch. Discussion ---------- Update custom_password_authenticator.rst Fixed TokenInterface use statement which was causing a "FatalErrorException: Compile Error:" to occur Commits ------- 4101d9b Update custom_password_authenticator.rst
Change title 'Accessing Public Methods' to 'Accessing Public Properties'. Title 'Accessing Public Properties' more in relation with the content.
This PR was submitted for the master branch but it was merged into the 2.4 branch instead (closes #3441). Discussion ---------- [Expression]Change title 'Accessing Public Methods' Change title 'Accessing Public Methods' to 'Accessing Public Properties' because it's more in relation with the content. Commits ------- b0e65e7 fixe tagline 8fc4ef8 Change title 'Accessing Public Methods'
This PR was merged into the 2.4 branch. Discussion ---------- Fix error in namespace when use TokenInterface Change the use statement of TokenInterface to the correct namespace (missing Token folder) Commits ------- a5a5668 Fix error in namespace when use TokenInterface
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When following instructions from the top, we create a Product with
$descriptionproperty. Later in example, with relations we need to add setDescription() on product.