Merge branch '5.4' into 6.0

* 5.4:
  [Console] Fix `Helper::removeDecoration` hyperlink bug
  Guard scripts from being run in non-CLI contexts
  Guard scripts from being run in non-CLI contexts
  a readonly property must not be reported as being writable

Author: fabpot

src/Symfony/Bridge/PhpUnit/bin/simple-phpunit.php

@@ -12,6 +12,10 @@
 // Please update when phpunit needs to be reinstalled with fresh deps:
 // Cache-Id: 2021-02-04 11:00 UTC
 
+if ('cli' !== \PHP_SAPI && 'phpdbg' !== \PHP_SAPI) {
+    throw new Exception('This script must be run from the command line.');
+}
+
 error_reporting(-1);
 
 global $argv, $argc;

src/Symfony/Bundle/FrameworkBundle/Resources/bin/check-unused-known-tags.php

@@ -9,6 +9,10 @@
  * file that was distributed with this source code.
  */
 
+if ('cli' !== \PHP_SAPI) {
+    throw new Exception('This script must be run from the command line.');
+}
+
 require dirname(__DIR__, 6).'/vendor/autoload.php';
 
 use Symfony\Bundle\FrameworkBundle\Tests\DependencyInjection\Compiler\UnusedTagsPassUtils;

src/Symfony/Component/Console/Helper/Helper.php

@@ -145,6 +145,8 @@ public static function removeDecoration(OutputFormatterInterface $formatter, ?st
         $string = $formatter->format($string ?? '');
         // remove already formatted characters
         $string = preg_replace("/\033\[[^m]*m/", '', $string ?? '');
+        // remove terminal hyperlinks
+        $string = preg_replace('/\\033]8;[^;]*;[^\\033]*\\033\\\\/', '', $string ?? '');
         $formatter->setDecorated($isDecorated);
 
         return $string;

src/Symfony/Component/Console/Tests/Helper/HelperTest.php

@@ -12,6 +12,7 @@
 namespace Symfony\Component\Console\Tests\Helper;
 
 use PHPUnit\Framework\TestCase;
+use Symfony\Component\Console\Formatter\OutputFormatter;
 use Symfony\Component\Console\Helper\Helper;
 
 class HelperTest extends TestCase
@@ -42,6 +43,16 @@ public function formatTimeProvider()
         ];
     }
 
+    public function decoratedTextProvider()
+    {
+        return [
+            ['abc', 'abc'],
+            ['abc<fg=default;bg=default>', 'abc'],
+            ["a\033[1;36mbc", 'abc'],
+            ["a\033]8;;http://url\033\\b\033]8;;\033\\c", 'abc'],
+        ];
+    }
+
     /**
      * @dataProvider formatTimeProvider
      *
@@ -52,4 +63,12 @@ public function testFormatTime($secs, $expectedFormat)
     {
         $this->assertEquals($expectedFormat, Helper::formatTime($secs));
     }
+
+    /**
+     * @dataProvider decoratedTextProvider
+     */
+    public function testRemoveDecoration(string $decoratedText, string $undecoratedText)
+    {
+        $this->assertEquals($undecoratedText, Helper::removeDecoration(new OutputFormatter(), $decoratedText));
+    }
 }

src/Symfony/Component/Console/Tests/Helper/TableTest.php

@@ -1595,6 +1595,31 @@ public function testWithColspanAndMaxWith()
 |                 |                 | nsectetur       |
 +-----------------+-----------------+-----------------+
 
+TABLE;
+
+        $this->assertSame($expected, $this->getOutputContent($output));
+    }
+
+    public function testWithHyperlinkAndMaxWidth()
+    {
+        $table = new Table($output = $this->getOutputStream(true));
+        $table
+            ->setRows([
+                ['<href=Lorem>Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod tempor</>'],
+            ])
+        ;
+        $table->setColumnMaxWidth(0, 20);
+        $table->render();
+
+        $expected =
+            <<<TABLE
++----------------------+
+| \033]8;;Lorem\033\\Lorem ipsum dolor si\033]8;;\033\\ |
+| \033]8;;Lorem\033\\t amet, consectetur \033]8;;\033\\ |
+| \033]8;;Lorem\033\\adipiscing elit, sed\033]8;;\033\\ |
+| \033]8;;Lorem\033\\do eiusmod tempor\033]8;;\033\\    |
++----------------------+
+
 TABLE;
 
         $this->assertSame($expected, $this->getOutputContent($output));

src/Symfony/Component/ErrorHandler/Resources/bin/extract-tentative-return-types.php

@@ -10,6 +10,10 @@
  * file that was distributed with this source code.
  */
 
+if ('cli' !== \PHP_SAPI) {
+    throw new Exception('This script must be run from the command line.');
+}
+
 // Run from the root of the php-src repository, this script generates
 // a table with all the methods that have a tentative return type.
 //

src/Symfony/Component/ErrorHandler/Resources/bin/patch-type-declarations

@@ -10,6 +10,10 @@
  * file that was distributed with this source code.
  */
 
+if ('cli' !== \PHP_SAPI) {
+    throw new Exception('This script must be run from the command line.');
+}
+
 if (\in_array('-h', $argv) || \in_array('--help', $argv)) {
     echo implode(PHP_EOL, [
         ' Patches type declarations based on "@return" PHPDoc and triggers deprecations for',

src/Symfony/Component/ExpressionLanguage/Resources/bin/generate_operator_regex.php

@@ -9,6 +9,10 @@
  * file that was distributed with this source code.
  */
 
+if ('cli' !== \PHP_SAPI) {
+    throw new Exception('This script must be run from the command line.');
+}
+
 $operators = ['not', '!', 'or', '||', '&&', 'and', '|', '^', '&', '==', '===', '!=', '!==', '<', '>', '>=', '<=', 'not in', 'in', '..', '+', '-', '~', '*', '/', '%', 'matches', '**'];
 $operators = array_combine($operators, array_map('strlen', $operators));
 arsort($operators);

src/Symfony/Component/Intl/Resources/bin/common.php

@@ -9,6 +9,10 @@
  * file that was distributed with this source code.
  */
 
+if ('cli' !== \PHP_SAPI) {
+    throw new Exception('This script must be run from the command line.');
+}
+
 define('LINE_WIDTH', 75);
 
 define('LINE', str_repeat('-', LINE_WIDTH)."\n");

src/Symfony/Component/Intl/Resources/bin/update-data.php

@@ -23,6 +23,10 @@
 use Symfony\Component\Intl\Locale;
 use Symfony\Component\Intl\Util\GitRepository;
 
+if ('cli' !== \PHP_SAPI) {
+    throw new Exception('This script must be run from the command line.');
+}
+
 require_once __DIR__.'/common.php';
 require_once __DIR__.'/autoload.php';