[web-profiler-bundle] Views don't follow Twig coding standards

[tcoch]

Symfony version(s) affected

6.2

Description

Several views don't follow Twig Coding Standards (https://twig.symfony.com/doc/3.x/coding_standards.html). Here's an example :

\vendor\symfony\web-profiler-bundle\Resources\views\Profiler\open.html.twig
l.12 c.73 : ERROR There should be 0 space before the "=" in the named arguments list.
l.12 c.75 : ERROR There should be 0 space after the "=" in the named arguments list.

I would like to add my humble contribution to Symfony by refactoring those file.

Also worth to notice : all errors can be found using friendsoftwig/twigcs. Would it be worth to add this check in the CI ?

How to reproduce

Execute .\vendor\bin\twigcs at the root of any Symfony 6.2 project.

Possible Solution

Refactor code manually. .\vendor\bin\twigcs indicates 401 violation(s) found in total (228 for WebProfilerBundle). I'd like to do it.

Additional Context

No response

[javiereguiluz]

I didn't know about twigcs. I've tested it a bit, and this would make the following changes in our templates:

-, with_context = false) }}
+, with_context=false) }}

-{{ 'post.num_comments'|trans({ 'count': post.comments|length }) }}
+{{ 'post.num_comments'|trans({'count': post.comments|length}) }}

I don't mind the second change, but the first one I think it looks worse than before.

So, before doing any changes, what do others things about this? Thanks!

[stof]

The space around = is configurable when using a custom rule set.

Note that the official Twig coding standards don't define the official rule for spacing for named arguments, so we cannot argue whether twigcs is right or wrong for the default config.

[carsonbot]

Hey, thanks for your report!
There has not been a lot of activity here for a while. Is this bug still relevant? Have you managed to find a workaround?

[carsonbot]

Friendly ping? Should this still be open? I will close if I don't hear anything.

[tcoch]

As mentioned by @stof there is currently no official set of rules for some of the criteria implemented in twigcs. Me, myself and I can't be judge and executioner on the subject. Either the Symfony community or the Core Team should define the standards first, and then we can work on respecting the defined standards.
Without standards, this issue should be closed.

[carsonbot]

Hey, thanks for your report!
There has not been a lot of activity here for a while. Is this bug still relevant? Have you managed to find a workaround?

[carsonbot]

Friendly reminder that this issue exists. If I don't hear anything I'll close this.

[carsonbot]

Hey,

I didn't hear anything so I'm going to close it. Feel free to comment if this is still relevant, I can always reopen!