[Validator] Fixed Choice when an empty array is used in the "choices" option #14448
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
webmozart
commented
Apr 22, 2015
webmozart
commented
| Q | A |
|---|---|
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | #13853 |
| License | MIT |
| Doc PR | - |
This was referenced Apr 22, 2015
|
This should be merged into 2.3. |
|
👍 |
1 similar comment
|
👍 |
|
|
||
| $this->buildViolation('myMessage') | ||
| ->setParameter('{{ value }}', '"baz"') | ||
| ->setCode(Choice::NO_SUCH_CHOICE_ERROR) |
There was a problem hiding this comment.
This cannot be merged like that in 2.3 since the constant doesn't exist.
webmozart
added a commit
that referenced
this pull request
Apr 24, 2015
…e "choices" option (webmozart) This PR was merged into the 2.6 branch. Discussion ---------- [Validator] Fixed Choice when an empty array is used in the "choices" option | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #13853 | License | MIT | Doc PR | - Commits ------- a5a41b2 [Validator] Fixed Choice when an empty array is used in the "choices" option
fabpot
added a commit
that referenced
this pull request
Apr 27, 2015
…e "choices" option (webmozart) This PR was merged into the 2.3 branch. Discussion ---------- [Validator] Fixed Choice when an empty array is used in the "choices" option | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #13853 | License | MIT | Doc PR | - This is a backport of #14448 for the 2.3 branch. Commits ------- 8bf8556 [Validator] Fixed Choice when an empty array is used in the "choices" option
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.