Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Cache] Add tags based invalidation + TagAwareRedisAdapter #19047

Merged
merged 1 commit into from Jun 17, 2016

Conversation

Projects
None yet
6 participants
@nicolas-grekas
Copy link
Member

commented Jun 14, 2016

Q A
Branch? master
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #18646
License MIT
Doc PR -

@nicolas-grekas nicolas-grekas changed the title Cache tag store [Cache] Add tags based invalidation + RedisTaggedAdapter Jun 14, 2016

@nicolas-grekas nicolas-grekas force-pushed the nicolas-grekas:cache-tag-store branch 3 times, most recently from 40f6846 to 8cc7f94 Jun 14, 2016

@javiereguiluz javiereguiluz added the Cache label Jun 14, 2016

@nicolas-grekas nicolas-grekas force-pushed the nicolas-grekas:cache-tag-store branch 3 times, most recently from ba4e17c to c2fb3b0 Jun 14, 2016

@nicolas-grekas

This comment has been minimized.

Copy link
Member Author

commented Jun 14, 2016

Rebased, RFR

@nicolas-grekas nicolas-grekas force-pushed the nicolas-grekas:cache-tag-store branch 7 times, most recently from a37fd52 to b2c84f0 Jun 14, 2016

@@ -1,7 +1,7 @@
Symfony PSR-6 implementation for caching
========================================

This component provides a strict [PSR-6](http://www.php-fig.org/psr/psr-6/)
This component provides a extended [PSR-6](http://www.php-fig.org/psr/psr-6/)

This comment has been minimized.

Copy link
@fabpot

fabpot Jun 17, 2016

Member

an extended

@nicolas-grekas nicolas-grekas force-pushed the nicolas-grekas:cache-tag-store branch 2 times, most recently from 229e33e to 15c2bea Jun 17, 2016

@nicolas-grekas nicolas-grekas changed the title [Cache] Add tags based invalidation + RedisTaggedAdapter [Cache] Add tags based invalidation + TagAwareRedisAdapter Jun 17, 2016

@nicolas-grekas nicolas-grekas force-pushed the nicolas-grekas:cache-tag-store branch from 15c2bea to 19764af Jun 17, 2016

@fabpot

This comment has been minimized.

Copy link
Member

commented Jun 17, 2016

Thank you @nicolas-grekas.

@fabpot fabpot merged commit 19764af into symfony:master Jun 17, 2016

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
fabbot.io Your code looks good.
Details

fabpot added a commit that referenced this pull request Jun 17, 2016

feature #19047 [Cache] Add tags based invalidation + TagAwareRedisAda…
…pter (nicolas-grekas)

This PR was merged into the 3.2-dev branch.

Discussion
----------

[Cache] Add tags based invalidation + TagAwareRedisAdapter

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | yes
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #18646
| License       | MIT
| Doc PR        | -

Commits
-------

19764af [Cache] Add tags based invalidation + TagAwareRedisAdapter

@nicolas-grekas nicolas-grekas deleted the nicolas-grekas:cache-tag-store branch Jun 17, 2016

nicolas-grekas added a commit that referenced this pull request Aug 7, 2016

feature #19524 [Cache] Add generic TagAwareAdapter wrapper (replaces …
…TagAwareRedisAdapter) (nicolas-grekas)

This PR was merged into the 3.2-dev branch.

Discussion
----------

[Cache] Add generic TagAwareAdapter wrapper (replaces TagAwareRedisAdapter)

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | yes
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | symfony/symfony-docs#6858

This PR replaces TagAwareRedisAdapter introduced in #19047 by a generic `TagAwareAdapter` that works with any two adapters.

Commits
-------

288308b [Cache] Add generic TagAwareAdapter wrapper (replaces TagAwareRedisAdapter)

@fabpot fabpot referenced this pull request Oct 27, 2016

Merged

Release v3.2.0-BETA1 #20317

@aik099

This comment has been minimized.

Copy link
Contributor

commented Sep 20, 2017

@nicolas-grekas ,

  1. I see, that TagAwareRedisAdapter was added here, but I don't see it anymore in Symfony 3.3.9. Was it removed?
  2. How do I create taggable cache adapter from file (for tag storage) and memcached (for data storage) adapters and then set it via framework.cache.app config option in app/config/config.yml?

Thanks.

@xabbuh

This comment has been minimized.

Copy link
Member

commented Sep 20, 2017

@aik099 The TagAwareRedisAdapter was replaced by a generic TagAwareAdapter in #19524.

@nicolas-grekas

This comment has been minimized.

Copy link
Member Author

commented Sep 20, 2017

@aik099 TagAwareRedisAdapter has never been released. Use TagAwareAdapter instead. For you other question, I invite you to use a support channel (we use github for dev, not support, see http://symfony.com/support)

@aik099

This comment has been minimized.

Copy link
Contributor

commented Sep 20, 2017

I've tried #support channel on Slack, but apparently nobody in there is using TagAwareAdapter and therefore we weren't able to get actually working solution :(

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.