Skip to content

Conversation

ReenExe
Copy link
Contributor

@ReenExe ReenExe commented Jul 28, 2016

Q A
Branch? 2.7
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets -
License MIT
Doc PR -

@stof
Copy link
Member

stof commented Jul 28, 2016

Please don't change the order between the return and the exception

@ReenExe
Copy link
Contributor Author

ReenExe commented Jul 28, 2016

@stof, this need to same style on master, #19406 (comment)

@fabpot
Copy link
Member

fabpot commented Jul 28, 2016

Thank you @ReenExe.

fabpot added a commit that referenced this pull request Jul 28, 2016
This PR was squashed before being merged into the 2.7 branch (closes #19470).

Discussion
----------

undefined offset fix (#19406)

| Q             | A
| ------------- | ---
| Branch?       | 2.7
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

Commits
-------

9813888 undefined offset fix (#19406)
@fabpot fabpot closed this Jul 28, 2016
This was referenced Jul 30, 2016
@fabpot fabpot mentioned this pull request Sep 3, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants