[Console] By default hide the short exception trace line from exception messages in Symfony's commands #27143
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolas-grekas
approved these changes
May 3, 2018
lyrixx
approved these changes
May 4, 2018
|
👍 but does it really qualify as a bugfix? |
yceruto
commented
May 4, 2018
| return $passwordQuestion->setValidator(function ($value) { | ||
| if ('' === trim($value)) { | ||
| throw new \Exception('The password must not be empty.'); | ||
| throw new InvalidArgumentException('The password must not be empty.'); |
There was a problem hiding this comment.
@chalasr It feels like a visual bug, so we're fixing the visual representation of the message, what do you think?
|
Thank you @yceruto. |
nicolas-grekas
added a commit
that referenced
this pull request
May 4, 2018
…rom exception messages in Symfony's commands (yceruto) This PR was merged into the 3.4 branch. Discussion ---------- [Console] By default hide the short exception trace line from exception messages in Symfony's commands | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - After #24131 this was in my contribution list since then. Maybe it should be taken as a good practice when we build console commands, **use the exception classes of the Console component as much as possible to show a better message style to the end user**. (See the before/after effect in the referenced PR) Commits ------- 11f3c45 Hide short exception trace by default
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After #24131 this was in my contribution list since then.
Maybe it should be taken as a good practice when we build console commands, use the exception classes of the Console component as much as possible to show a better message style to the end user.
(See the before/after effect in the referenced PR)