New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FrameworkBundle][TwigBridge] Fix BC break from strong dependency on CSRF token storage #27454

Merged
merged 1 commit into from May 31, 2018

Conversation

Projects
None yet
4 participants
@tgalopin
Contributor

tgalopin commented May 31, 2018

Q A
Branch? 4.1
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets -
License MIT
Doc PR -

The PR #25197 introduced the csrf_token function in Twig. This extension relies on CsrfTokenManagerInterface, which itself relies on the session. In some contexts such as when sessions are stored in Redis and we try to warmup the cache in CLI without Redis available, this makes the process fails.

This PR fixes this by using a Twig runtime instead of a direct extension to avoid a strong dependency on CsrfTokenManagerInterface.

@nicolas-grekas nicolas-grekas added this to the 4.1 milestone May 31, 2018

@fabpot

fabpot approved these changes May 31, 2018

@fabpot

This comment has been minimized.

Member

fabpot commented May 31, 2018

Thank you @tgalopin.

@fabpot fabpot merged commit 68994a6 into symfony:4.1 May 31, 2018

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
fabbot.io Your code looks good.
Details

fabpot added a commit that referenced this pull request May 31, 2018

bug #27454 [FrameworkBundle][TwigBridge] Fix BC break from strong dep…
…endency on CSRF token storage (tgalopin)

This PR was merged into the 4.1 branch.

Discussion
----------

[FrameworkBundle][TwigBridge] Fix BC break from strong dependency on CSRF token storage

| Q             | A
| ------------- | ---
| Branch?       | 4.1
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

The PR #25197 introduced the `csrf_token` function in Twig. This extension relies on `CsrfTokenManagerInterface`, which itself relies on the session. In some contexts such as when sessions are stored in Redis and we try to warmup the cache in CLI without Redis available, this makes the process fails.

This PR fixes this by using a Twig runtime instead of a direct extension to avoid a strong dependency on `CsrfTokenManagerInterface`.

Commits
-------

68994a6 [FrameworkBundle][TwigBridge] Fix BC break from strong dependency on CSRF token storage

@tgalopin tgalopin deleted the tgalopin:4.1-fix-twig-csrf branch May 31, 2018

@fabpot fabpot referenced this pull request Jun 25, 2018

Merged

Release v4.1.1 #27706

nicolas-grekas added a commit that referenced this pull request Jul 4, 2018

minor #27719 [FrameworkBundle] add conflict for non-compatible TwigBr…
…idge version (xabbuh)

This PR was merged into the 4.1 branch.

Discussion
----------

[FrameworkBundle] add conflict for non-compatible TwigBridge version

| Q             | A
| ------------- | ---
| Branch?       | 4.1
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #27713
| License       | MIT
| Doc PR        |

The argument was dropped in #27454.

Commits
-------

251e684 add conflict for non-compatible TwigBridge version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment