[HttpKernel] Log/Collect exceptions at prio 0 #27562
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
updating the changelog file of the component lgtm, no need for 4.1.1 there imho. |
nicolas-grekas
approved these changes
Jun 9, 2018
fabpot
approved these changes
Jun 10, 2018
|
Thank you @ro0NL. |
fabpot
added a commit
that referenced
this pull request
Jun 10, 2018
This PR was squashed before being merged into the 4.1 branch (closes #27562). Discussion ---------- [HttpKernel] Log/Collect exceptions at prio 0 | Q | A | ------------- | --- | Branch? | 4.1 | Bug fix? | yes | New feature? | no | BC breaks? | no, fixes one | Deprecations? | no | Tests pass? | yes <!-- please add some, will be required by reviewers --> | Fixed tickets | #27440 | License | MIT | Doc PR | symfony/symfony-docs#... <!-- required for new features --> So that it runs after the security exception listener, which runs at prio 1. Im not sure what to do with the (wrong) changelog entry for 4.1.0 at this point.. should we add a new entry for 4.1.1? Commits ------- 85b832b [HttpKernel] Log/Collect exceptions at prio 0
Merged
francoispluchino
added a commit
to klipperdev/klipper
that referenced
this pull request
Sep 1, 2020
To unlog the managed exceptions since symfony/symfony#27562
francoispluchino
added a commit
to klipperdev/api-bundle
that referenced
this pull request
Sep 1, 2020
To unlog the managed exceptions since symfony/symfony#27562
francoispluchino
added a commit
to klipperdev/security-bundle
that referenced
this pull request
Sep 1, 2020
To unlog the managed exceptions since symfony/symfony#27562
francoispluchino
added a commit
to klipperdev/security-oauth
that referenced
this pull request
Sep 1, 2020
To unlog the managed exceptions since symfony/symfony#27562
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So that it runs after the security exception listener, which runs at prio 1.
Im not sure what to do with the (wrong) changelog entry for 4.1.0 at this point.. should we add a new entry for 4.1.1?