New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HttpKernel] Log/Collect exceptions at prio 0 #27562

Merged
merged 1 commit into from Jun 10, 2018

Conversation

Projects
None yet
4 participants
@ro0NL
Contributor

ro0NL commented Jun 9, 2018

Q A
Branch? 4.1
Bug fix? yes
New feature? no
BC breaks? no, fixes one
Deprecations? no
Tests pass? yes
Fixed tickets #27440
License MIT
Doc PR symfony/symfony-docs#...

So that it runs after the security exception listener, which runs at prio 1.

Im not sure what to do with the (wrong) changelog entry for 4.1.0 at this point.. should we add a new entry for 4.1.1?

@ro0NL ro0NL changed the base branch from master to 4.1 Jun 9, 2018

@nicolas-grekas

This comment has been minimized.

Member

nicolas-grekas commented Jun 9, 2018

updating the changelog file of the component lgtm, no need for 4.1.1 there imho.

@nicolas-grekas nicolas-grekas added this to the 4.1 milestone Jun 9, 2018

@fabpot

fabpot approved these changes Jun 10, 2018

@fabpot

This comment has been minimized.

Member

fabpot commented Jun 10, 2018

Thank you @ro0NL.

@fabpot fabpot merged commit 85b832b into symfony:4.1 Jun 10, 2018

1 of 3 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
fabbot.io Your code looks good.
Details

fabpot added a commit that referenced this pull request Jun 10, 2018

bug #27562 [HttpKernel] Log/Collect exceptions at prio 0 (ro0NL)
This PR was squashed before being merged into the 4.1 branch (closes #27562).

Discussion
----------

[HttpKernel] Log/Collect exceptions at prio 0

| Q             | A
| ------------- | ---
| Branch?       | 4.1
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no, fixes one
| Deprecations? | no
| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
| Fixed tickets | #27440
| License       | MIT
| Doc PR        | symfony/symfony-docs#... <!-- required for new features -->

So that it runs after the security exception listener, which runs at prio 1.

Im not sure what to do with the (wrong) changelog entry for 4.1.0 at this point.. should we add a new entry for 4.1.1?

Commits
-------

85b832b [HttpKernel] Log/Collect exceptions at prio 0

@ro0NL ro0NL deleted the ro0NL:log-prio branch Jun 10, 2018

@fabpot fabpot referenced this pull request Jun 25, 2018

Merged

Release v4.1.1 #27706

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment