New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DI] Avoid leaking unused env placeholders #27681

Merged
merged 1 commit into from Jun 23, 2018

Conversation

Projects
None yet
3 participants
@ro0NL
Contributor

ro0NL commented Jun 22, 2018

Q A
Branch? 4.1
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #27486
License MIT
Doc PR symfony/symfony-docs#...

This PR avoids leaking out unused env placeholders, those are not resolved in resolveEnvPlaceholders() and such. As a result they are dumped as-is.

cc @nicolas-grekas

@ro0NL

This comment has been minimized.

Contributor

ro0NL commented Jun 22, 2018

Hm tests are failing.

Status: needs work

@nicolas-grekas nicolas-grekas added this to the 4.1 milestone Jun 22, 2018

@ro0NL

This comment has been minimized.

Contributor

ro0NL commented Jun 22, 2018

Tests added.

Status: needs review

@nicolas-grekas

This comment has been minimized.

Member

nicolas-grekas commented Jun 23, 2018

Thank you @ro0NL.

@nicolas-grekas nicolas-grekas merged commit 41f8494 into symfony:4.1 Jun 23, 2018

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
fabbot.io Your code looks good.
Details

nicolas-grekas added a commit that referenced this pull request Jun 23, 2018

bug #27681 [DI] Avoid leaking unused env placeholders (ro0NL)
This PR was merged into the 4.1 branch.

Discussion
----------

[DI] Avoid leaking unused env placeholders

| Q             | A
| ------------- | ---
| Branch?       | 4.1
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no     <!-- see https://symfony.com/bc -->
| Deprecations? | no
| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
| Fixed tickets | #27486
| License       | MIT
| Doc PR        | symfony/symfony-docs#... <!-- required for new features -->

This PR avoids leaking out unused env placeholders, those are not resolved in `resolveEnvPlaceholders()` and such. As a result they are dumped as-is.

cc @nicolas-grekas

Commits
-------

41f8494 [DI] Avoid leaking unused env placeholders

@ro0NL ro0NL deleted the ro0NL:di/env branch Jun 23, 2018

@fabpot fabpot referenced this pull request Jun 25, 2018

Merged

Release v4.1.1 #27706

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment