New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Routing] ignore trailing slash for non-GET requests #29441

Merged
merged 1 commit into from Dec 3, 2018

Conversation

Projects
None yet
3 participants
@nicolas-grekas
Member

nicolas-grekas commented Dec 3, 2018

Q A
Branch? 3.4
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #29410
License MIT
Doc PR -

Another test case provided by @peterrehm in the linked issue - the dumped matcher already passes this test - but the non-dumped one doesn't (neither does the dumped one in 4.1 - I'll fix while merging up)

@peterrehm

This comment has been minimized.

Contributor

peterrehm commented Dec 3, 2018

Thanks for your awesome support!

@nicolas-grekas nicolas-grekas merged commit 7521af7 into symfony:3.4 Dec 3, 2018

2 of 3 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
fabbot.io Your code looks good.
Details

nicolas-grekas added a commit that referenced this pull request Dec 3, 2018

bug #29441 [Routing] ignore trailing slash for non-GET requests (nico…
…las-grekas)

This PR was merged into the 3.4 branch.

Discussion
----------

[Routing] ignore trailing slash for non-GET requests

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #29410
| License       | MIT
| Doc PR        | -

Another test case provided by @peterrehm in the linked issue - the dumped matcher already passes this test - but the non-dumped one doesn't (neither does the dumped one in 4.1 - I'll fix while merging up)

Commits
-------

7521af7 [Routing] ignore trailing slash for non-GET requests
@peterrehm

This comment has been minimized.

Contributor

peterrehm commented Dec 4, 2018

Can confirm it works now!

@nicolas-grekas nicolas-grekas deleted the nicolas-grekas:routing-fix-34 branch Dec 10, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment