Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Workflow] Added support for many inital places #30468

Merged
merged 1 commit into from Mar 22, 2019

Conversation

Projects
None yet
4 participants
@lyrixx
Copy link
Member

lyrixx commented Mar 6, 2019

Q A
Branch? master
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? yes
Tests pass? yes
Fixed tickets #30080
License MIT
Doc PR

@lyrixx lyrixx force-pushed the lyrixx:w-mutli-init-places branch from 35880b2 to f623102 Mar 6, 2019

@Korbeil
Copy link
Contributor

Korbeil left a comment

Thanks a lot for this PR, this will help us improve how we use workflow 😄

Quick notice, I did not see tests with multiple initial places, I think it should be better to add atleast one.

Also, is there a reason you don't throw an Exception when we have multiple initial places with single_state marking store ?

@nicolas-grekas nicolas-grekas added this to the next milestone Mar 7, 2019

Show resolved Hide resolved UPGRADE-4.3.md Outdated

@lyrixx lyrixx added the Workflow label Mar 12, 2019

@lyrixx lyrixx changed the title Added support for many inital places [Workflow] Added support for many inital places Mar 12, 2019

@lyrixx

This comment has been minimized.

Copy link
Member Author

lyrixx commented Mar 12, 2019

Also, is there a reason you don't throw an Exception when we have multiple initial places with single_state marking store ?

I will do that once #29457 is merged. It will be much more easier

@lyrixx lyrixx force-pushed the lyrixx:w-mutli-init-places branch from f623102 to 9a9184d Mar 13, 2019

@lyrixx

This comment has been minimized.

Copy link
Member Author

lyrixx commented Mar 13, 2019

Here we Go. I updated validators and added test 👍

@Korbeil
Copy link
Contributor

Korbeil left a comment

Thanks ! 👍

@lyrixx lyrixx force-pushed the lyrixx:w-mutli-init-places branch 2 times, most recently from 9c10c81 to 56c6090 Mar 13, 2019

@lyrixx lyrixx force-pushed the lyrixx:w-mutli-init-places branch 2 times, most recently from a3ca1b6 to 66119d5 Mar 16, 2019

@lyrixx lyrixx force-pushed the lyrixx:w-mutli-init-places branch from 66119d5 to 1af1bf2 Mar 20, 2019

@lyrixx lyrixx merged commit 1af1bf2 into symfony:master Mar 22, 2019

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
fabbot.io Your code looks good.
Details

lyrixx added a commit that referenced this pull request Mar 22, 2019

feature #30468 [Workflow] Added support for many inital places (lyrixx)
This PR was merged into the 4.3-dev branch.

Discussion
----------

[Workflow] Added support for many inital places

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | yes
| BC breaks?    | no
| Deprecations? | yes
| Tests pass?   | yes
| Fixed tickets | #30080
| License       | MIT
| Doc PR        |

Commits
-------

1af1bf2 Added support for many inital places

@lyrixx lyrixx deleted the lyrixx:w-mutli-init-places branch Mar 22, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.