Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WebLink] implement PSR-13 directly #33122

Merged
merged 1 commit into from Aug 12, 2019

Conversation

@nicolas-grekas
Copy link
Member

commented Aug 12, 2019

Q A
Branch? 4.4
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets -
License MIT
Doc PR symfony/symfony-docs#12144

Implementing PSR-13 is simple enough and the repo we're using is freezed.

This also allows us to add some type declarations. We're going to need them before merging #30323.

@nicolas-grekas nicolas-grekas added this to the next milestone Aug 12, 2019

@nicolas-grekas nicolas-grekas requested a review from dunglas as a code owner Aug 12, 2019

@nicolas-grekas nicolas-grekas force-pushed the nicolas-grekas:weblink branch from a81e5d3 to b570ee1 Aug 12, 2019

@lyrixx

lyrixx approved these changes Aug 12, 2019

@nicolas-grekas nicolas-grekas merged commit b570ee1 into symfony:4.4 Aug 12, 2019

2 of 3 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
fabbot.io Your code looks good.
Details

nicolas-grekas added a commit that referenced this pull request Aug 12, 2019

feature #33122 [WebLink] implement PSR-13 directly (nicolas-grekas)
This PR was merged into the 4.4 branch.

Discussion
----------

[WebLink] implement PSR-13 directly

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | no
| New feature?  | yes
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

Implementing PSR-13 is simple enough and the repo we're using is [freezed](https://github.com/php-fig/link-util/pulls).

This also allows us to add some type declarations. We're going to need them before merging #30323.

Commits
-------

b570ee1 [WebLink] implement PSR-13 directly

@nicolas-grekas nicolas-grekas deleted the nicolas-grekas:weblink branch Aug 12, 2019

javiereguiluz added a commit to symfony/symfony-docs that referenced this pull request Aug 13, 2019

minor #12144 Use PSR-13 implementation from WebLink component (nicola…
…s-grekas)

This PR was merged into the 4.4 branch.

Discussion
----------

Use PSR-13 implementation from WebLink component

Follows symfony/symfony#33122

Commits
-------

0674414 Use PSR-13 implementation from WebLink component
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.