[Messenger] fix compatibility with Doctrine DBAL 4 #52476
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
xabbuh
commented
Nov 6, 2023
xabbuh
commented
| Q | A |
|---|---|
| Branch? | 5.4 |
| Bug fix? | no |
| New feature? | no |
| Deprecations? | no |
| Issues | |
| License | MIT |
|
The idea behind that feature was that Symfony could leverage the query builder for building the "skip locked rows" query. |
xabbuh
force-pushed
the
doctrine-dbal-6191
branch
4 times, most recently
from
97aacef to
2f059e0
Compare
|
Thanks for your feedback. I guess it's better now. |
src/Symfony/Component/Messenger/Bridge/Doctrine/Transport/Connection.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/Messenger/Bridge/Doctrine/Transport/Connection.php
Show resolved
Hide resolved
src/Symfony/Component/Messenger/Bridge/Doctrine/Transport/Connection.php
Outdated
Show resolved
Hide resolved
xabbuh
force-pushed
the
doctrine-dbal-6191
branch
from
2f059e0 to
55b000e
Compare
nicolas-grekas
approved these changes
Nov 7, 2023
stof
reviewed
Nov 7, 2023
| if (preg_match('/FROM (.+) WHERE/', (string) $sql, $matches)) { | ||
|
|
||
| if (method_exists(QueryBuilder::class, 'forUpdate')) { | ||
| $query->forUpdate(); |
There was a problem hiding this comment.
For the case of the oracle platform, this is now applying the lock on the inner query and not the outer one (see the specific code below). Is this expected ?
There was a problem hiding this comment.
it's probably better not to change the outcome here, updated
xabbuh
force-pushed
the
doctrine-dbal-6191
branch
from
55b000e to
fca96ac
Compare
stof
approved these changes
Nov 7, 2023
|
Thank you @xabbuh. |
This was referenced Nov 10, 2023
Merged
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.