[Asset][BrowserKit][Cache][Console][CssSelector] Use CPP #53347
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
OskarStark
commented
Jan 2, 2024
OskarStark
commented
| Q | A |
|---|---|
| Branch? | 7.1 |
| Bug fix? | no |
| New feature? | no |
| Deprecations? | no |
| Issues | -- |
| License | MIT |
Member
|
It'd be great if you could group your next PRs on the topic in a bigger one 🙏 |
Contributor
Author
|
Sure, let this one open, I can work on this PR |
OskarStark
changed the title
Contributor
Author
|
Can be merged please |
wouterj
reviewed
Jan 4, 2024
OskarStark
commented
Jan 4, 2024
OskarStark
commented
Jan 4, 2024
wouterj
reviewed
Jan 4, 2024
src/Symfony/Component/Console/Formatter/OutputFormatterStyleStack.php
Outdated
Show resolved
Hide resolved
nicolas-grekas
force-pushed
the
asset-cpp
branch
from
3c2f991 to
cf1f695
Compare
Member
|
Thank you @OskarStark. |
nicolas-grekas
added a commit
that referenced
this pull request
Jan 8, 2024
This PR was merged into the 7.1 branch. Discussion ---------- [Cache] revert property introduction | Q | A | ------------- | --- | Branch? | 7.1 | Bug fix? | no | New feature? | no | Deprecations? | no | Issues | | License | MIT This property sneaked into in #53347 (probably by mistake). Commits ------- 066420f revert property introduction
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.